Error if not declaring width and height

Hi, I've just installed this very interesting extension using the default values and config but i have a problem:
if I leave all as default, when I save the page in which I have embedded a PDF using <pdf>File:name.pdf</pdf>, I get this error message at the top of the page:
Notice: Undefined index: height in C:\wamp\www\kb\extensions\PDFEmbed\PDFEmbed.hooks.php on line 66. However I can see the PDF embedded into the page

The error disappear if I use <pdf width="xxx" height="yyy">File:name.pdf</pdf>

I tried to explicit the WIDTH and HEIGHT parameters in the config.php but without any success.

I use mediawiki 1.19 85.40.211.228 11:26, 28 February 2014 (UTC)

Hi,

I have the same problem. I've found an explanation : if you don't have any height or width, the following lines (65-66) in PDFEmbed.hooks.php make a warning :

		$width  = ($args['width'] > 0 ? intval($args['width']) : intval($pdfEmbed['width']));
		$height = ($args['height'] > 0 ? intval($args['height']) : intval($pdfEmbed['height']));

So, waiting next release of PDFEmbed, just before these two lines above, insert these lines :

		if (!isset($args['width'])) {
			$args['width'] = 0;
		}
		if (!isset($args['height'])) {
			$args['height'] = 0;
		}

I'm not proud of myself, 'cause that's not clean, but it works! Cahuet (talk) 17:27, 3 November 2014 (UTC)

I opened a new issue on the Github project for this. I should be able to get to it this week or next.

https://github.com/Alexia/PDFEmbed/issues/3 Alexia E. Smith (talk) 17:49, 3 November 2014 (UTC)

I just put out the official fix along with a couple other fixes. Alexia E. Smith (talk) 20:23, 4 November 2014 (UTC)

Thank you very much Alexia... I obviously prefer your code. 38.127.136.234 00:57, 5 November 2014 (UTC)

parser error

i'm using mediawiki 1.19.2 and when using this extension, i get a parser error at line 15 in PDFEmbed.i18n.php. 106.68.249.46 05:45, 6 March 2014 (UTC)

I've put in a pull request in the git repository for this extension that should fix your issue. Sounds like you're using a PHP version that doesn't support square bracket arrays, which is a new feature in PHP 5.4 and newer versions. If you don't want to wait for the pull request to be merged, you can go ahead and copy the change I made to your MediaWiki installation. :)

Hopefully that works! GeorgeBarnick (talk) 05:50, 6 March 2014 (UTC)

In follow up to my last message, the author of the extension has created a 'compat' branch in the extension's GitHub repository. Go ahead and download that branch and replace the incompatible version of the extension you have, and things should work fine. :) Let me know if you have any further issues with the extension. GeorgeBarnick (talk) 06:33, 6 March 2014 (UTC)

Thanks for that patch. However, there's another array fix in PDFEmbed.hooks.php in line 37. Wess (talk) 12:54, 25 August 2015 (UTC)

de.json

Hi again, another

de.json

{
	"@metadata": {
		"authors": []
	},
	"pdfembed": "PDF Embed",
	"pdfembed_description": "Media-Handler-Extension für PDF-Dateien.",
	"embed_pdf_no_permission": "Zum Einbetten von PDFs fehlen entsprechende Benutzerrechte.",
	"embed_pdf_blank_file": "URL bzw. Dateipfad zum Einbetten ist leer.",
	"embed_pdf_invalid_file": "URL bzw. Dateipfad existiert nicht.",
	"embed_pdf_invalid_user": "Ein ungültiger Benutzer wurde angegeben.",
	"pdf_not_supported": "Die PDF-Datei wurde nicht richtig geladen oder der verwendete Browser kann kein PDF anzeigen. Das PDF <a href=\"$1\">$2</a> herunterladen."
}

Cheers Messerjokke79 (talk) 22:20, 15 November 2014 (UTC)

I have created a pull request for Alexia. Thanks for providing the translation. [[kgh]] (talk) 15:17, 17 November 2014 (UTC)

syntax error, unexpected '['

When I try to use runJobs with this extension enable I get this error PHP Parse error: syntax error, unexpected '[' in /var/www/html/mw/extensions/PDFEmbed/PDFEmbed.php on line 16 Legaulph (talk) 12:24, 23 February 2015 (UTC)

Make sure to upgrade your PHP installation to 5.4 or higher. Otherwise if you can not upgrade then use the 5.3 compatibility branch. Alexia E. Smith (talk) 15:24, 23 February 2015 (UTC)

Thank you for your response

I'm currently using

MediaWiki 1.23.8

PHP 5.4.16 (apache2handler)

MySQL 5.6.19-log

Semantic MediaWiki 2.1 148.177.1.211 20:53, 24 February 2015 (UTC)

Thank you Legaulph (talk) 17:41, 1 April 2016 (UTC)

Directory Path

So I've gathered this looks in the "images" directory as the default location for the PDF referenced in the wiki code. Is there a way to adjust the directory path that the extension looks to for the file?

I'd like to places all PDF files in a folder called "documents" that would reside in the "images" directory. Jpwake77 (talk) 19:16, 20 April 2015 (UTC)

PDFEmbed uses Mediawiki's built in upload system. For legacy Mediawiki reasons this folder is named images and does not actually really mean it is only for images. Alexia E. Smith (talk) 22:20, 28 April 2015 (UTC)

any chances to have a "zoom" parameter/option?

Hello, thanks for your good work! I just wanted to know if there are any chances to get a "zoom" parameter for this extension same as it works for "width" or "height". Thanks! Goliva1981 (talk) 12:36, 4 June 2015 (UTC)

not working on android mobile

perhaps it will be possible in the future to have an update of this extension ( I use the 1.1.2 version ) ?

because this plugin doesn't work on mobile (but it is OK on pc window)

here is an exemple of wordpress plugin which works with pc and mobile

it is very nice to view the pdf document directly on the web page of my mobile (I check that it works with chrome, firefox, dolphin android browser

from playstore)

Chantoune (talk) 14:27, 15 February 2016 (UTC)

Discussion handled at Project:Support desk/Flow/2016/02#h-PDFembed_doesn't_work_on_Android-2016-02-14T18:10:00.000Z Ciencia Al Poder (talk) 19:04, 21 February 2016 (UTC)

Users unable to embed PDF

When trying to embed a PDF the user is getting:

"you don't have permission to embed pdf files"

If I edit as admin and save it I get the same error.

I have to delete it save then edit and add the link and save then it is successful Legaulph (talk) 14:57, 23 February 2016 (UTC)

Are you using <pdf>File:FooBar.pdf</pdf> ?

I just had the same issue and am kicking myself for it now. Pisnaz (talk) 23:49, 22 March 2016 (UTC)

Having the same issue as well any ideas 165.228.93.174 (talk) 08:42, 29 March 2016 (UTC)

Seems I had other issues as well once I started using my bot and normal users.

There is a embed_pdf permission showing now, that I did not see before. It seems it is only on Administrators by default.

For my Bot uploads I simply added in $wgGroupPermissions['bot']['embed_pdf'] = true; to my LocalSettings.php

I am running:

Hope that helps. Also be careful as blanket permissions might cause issues. Pisnaz (talk) 14:35, 30 March 2016 (UTC)

This should be said in the configuration section of the extension article. Thanks! RockSheep (talk) 17:12, 25 January 2019 (UTC)

Yes that works for me as well Legaulph (talk) 17:39, 1 April 2016 (UTC)

That worked great! now that that has a permission line I can get my users to see or embed. Thanks a bunch! 209.159.235.12 (talk) 13:58, 17 April 2017 (UTC)

Hello,

I have added the

$wgGroupPermissions['*']['embed_pdf'] = true;

to my LocalSettings.php but I still get the error-message "you don't have permission to embed pdf files". MW Version 1.31.1

What else can I check?

Thanks in advance! 77.20.30.72 (talk) 16:44, 3 January 2019 (UTC)

Anyone on this problem ? 217.19.146.36 (talk) 12:41, 1 February 2019 (UTC)

Hi,

I've installed the Extionsion, and can upload PDF files to our MediaWiki 1.31.

However, after linking to the uploaded file, and saving the page, a empty square shows, where the PDF image should be.

When I check the source code of the page, an URL is listed, and when I click on the URL, the PDF is opened.

All this happens in Google Chrome.

I also installed this extension in our TestWiki, and there I have no issues! Same browser., same Wiki version IMTS-TB (talk) 12:07, 14 February 2020 (UTC)

Hi

You have to replace line 92 in the PDFEmbed.hooks.pdf file

OLD

'src' => $file->getFullUrl().'#page='.$page,

NEW

'src' => preg_replace("/^http:/i", "https:", $file->getFullUrl()).'#page='.$page,

When not changed, you get an empty square, cause your side is loaded with https and the extension uses http, mixed content, blocked in chrome for example. 212.236.21.221 (talk) 11:56, 17 June 2020 (UTC)

Because my website uses https protocol, the embedding of PDF mixed (http (pdf url) and https page).

To get this working in the pdfembed for version 1.35 I added the line

               $url = str_replace("http:", "https:", $url); after line 190.

That fixed it for me. 2001:1C05:480:AA00:E27B:D6A9:1279:1933 (talk) 10:54, 2 February 2024 (UTC)

In case anyone is reading this in 2023

I had the same problem but only admins could embed, with ordinary users getting no dice. In my case this was a permissions problem which can be verified via special:user group rights

admins had embed_pdf set, but ordinary users did not.

The fix is to edit LocalSettings.php and add:

$wgGroupPermissions['user']['embed_pdf'] = true; Polymath uk (talk) 11:08, 10 January 2023 (UTC)

Problem with passing parameters inside a template

Hello,

The users on our wiki are used to embeding lots of different file formats. They use syntax similar to this:

{{Template:someTemplate
  |file=some file.pdf
  |size=L
  }}
  

We are using sizes 'L', 'M', .. to get a unified look on all of the pages.

The height and width is then controlled in our template, which translates it from 'L' to some preset number. This works for many different use cases.

The problem with PDFEmbed is, that I'm not able to get it to function with a 'dynamic' parameter.. I would need to use something like this:

<pdf width="{{{width}}}" height="{{{height}}}">File:SOme pdf file.pdf</pdf>

But '{{{parameter}}}' just doesn't get parsed correctly..

Thanks for all of the help (and sorry if my understanding of the extension is subpar - i'm new to mediawiki and php...)

Thanks, Domen Domen988 (talk) 14:50, 19 May 2016 (UTC)

Same with me:

<pdf page="{{{myPageNr|}}">File:example.pdf</pdf>

is ignored. PDF starts always at page 1. But if I do a hard code

<pdf page="3">File:example.pdf</pdf>

everything is alright.

A fix would be great! Thanks in advance. M art in (talk) 10:47, 3 November 2016 (UTC)

How to disable the tool option to prefent non-users to download

Would it be possible to block unregistered users to download the pdf file.

Have a look here: Harry H. Arends 20:33, 27 November 2016 (UTC)

PDFEmbed.php is missing in Dowload Version 2.0

Not working with #var: ?

File Usage doesn't recognize usage of embedded pdf

Hi,

We uploaded a PDF to our MediaWiki and then used PDFEmbed to show the file on a page. I noticed that the File Usage section of the uploaded PDF has the message "There are no pages that link to this file."

The PDF shows up just fine. Is there a way to make MediaWiki recognize that the file has been used when embedding with this plugin? We embedded using the following syntax:

<pdf>File:filename.pdf</pdf>

Thanks,

-Dan Daniel.Humphrey (talk) 19:51, 13 April 2017 (UTC)

Any chances to review this? RodolfoEBDR (talk) 20:07, 31 July 2018 (UTC)

Is the version on Git correct

So i had problem of showing the PDF embedded ion the browser.

There was still version 1.12 on the wiki so i got the new 2.0.0 version and uploaded it.

Checking the version at but is show version 1.12 installed.

And <pdf>Bestand:KT00804.pdf|KT 00.804</pdf> gives this text on the page: The URL or file path given does not exist.

Strange while the file is here:

Whats wrong??? Gharryh (talk) 10:30, 7 May 2017 (UTC)

embed pdf error

i have installed pdfEmbed 2.0.1 in mediawiki and have uploaded the pdf document thru upload files in mediawiki. its showing a warning as application/PDF privacy consideration and the output on the pdf embed page showing as "The URL or file path given does not exist."

Please help me to resolve this issue. 182.72.144.54 (talk) 11:31, 2 August 2017 (UTC)

I have the same error,

Since 3 months before it works fine, ..

Can you help us?

Thank .

guindelo 83.247.136.44 (talk) 12:48, 9 April 2018 (UTC)

I have the same error,

Since 3 months before it works fine, ..

Can you help us?

Thank .

guindelo Guindelo (talk) 12:50, 9 April 2018 (UTC)

Same issue for me also, Pls suggest any other extension or any fixed build. Pooja2425 (talk) 11:23, 17 September 2021 (UTC)

Automatically fit to width

Hi, is it possible to command the pdf to automatically fit to width? 212.83.194.34 (talk) 09:58, 14 June 2018 (UTC)

Change the file PDFEmbed.hooks

static private function embed(File $file, $width, $height, $page) {

       return Html::rawElement(

           'iframe',

           [

               //'width' => $width,

               'width' => '100%',

               'height' => $height,

               'src' => $file->getFullUrl().'#page='.$page,

               'style' => 'max-width: 100%;'

           ]

       );

   } RodolfoEBDR (talk) 14:23, 2 August 2018 (UTC)

IE 11 Compatibility problem

Note that this extension will not necessarily work on IE as intended. On my testing on a new install of IE 11, the pdf was not embedded on the page but instead opened a prompt to download the file. See: https://stackoverflow.com/a/12974315/498730 for more info that I have found about this problem. VOIstri (talk) 18:36, 21 July 2018 (UTC)

Blank Frame and no PDF displaying

Content blocked by Chrome Security

After MediaWiki 1.33 upgrade, embedded box is displayed, but it is always empty. 82.5.14.66 (talk) 10:02, 8 July 2019 (UTC)

I found that the pdf content appeared on another computer and subsequently realised that chrome was blocking the content because it would not run an "unsafe script". This probably happened because my wiki site had no security certificate. 82.5.14.66 (talk) 07:27, 9 July 2019 (UTC)

Add the following code at the bottom of your LocalSettings.php:

Where do I find my LocalSettings.php? 68.36.79.230 (talk) 15:15, 2 March 2020 (UTC)

Found it.

68.36.79.230 (talk) 15:42, 2 March 2020 (UTC)

Use of "Parser::disableCache" was deprecated in MediaWiki 1.28.

Use of Parser::disableCache was deprecated in MediaWiki 1.28. [Called from PDFEmbed::generateTag in xxxxxxxxxxxxxxxxxxxx  PDFEmbed\PDFEmbed.hooks.php at line 39] in xxxxxxxxxxxxxxxxx xxxxdebug\MWDebug.php

Using page number as variable in template

Error ShellDisabledError on pdf upload

I had this error in 1.33 while uploadinf a pdf. Every pdf.

I do not understand why, but, looking for help in talks, I remembered I activate PDFHandler in the Wiki installation.

Disabled the default extension and now everything works fine.

So, PDFEmbed and PDFHandler does not works fine togheter. 2.239.139.214 (talk) 00:07, 8 May 2020 (UTC)

It worked for me too on MW 1.31.

Thank you so much. 93.41.255.164 (talk) 10:54, 30 December 2020 (UTC)

Which browsers is it broken on

The page says that it only works on some browsers from Mediawiki 1.30 onwards. Could we have a list of which browsers work, and which don't now. Vicarage (talk) 10:08, 25 July 2020 (UTC)

MW 1.35 Call to undefined method Parser::disableCache()

PDFEmbed/PDFEmbed.hooks.php: Call to undefined method Parser::disableCache() Seppl2013 (talk) 14:04, 11 October 2020 (UTC)

I created a (hopefully) working fix at https://github.com/WolfgangFahl/PDFEmbed and would love to share it we a pull request and get feeback on it. See also https://gitlab.com/hydrawiki/extensions/PDFEmbed/-/issues/19 Seppl2013 (talk) 10:11, 12 October 2020 (UTC)

Thanks for working on this and providing a way out. [[kgh]] (talk) 16:10, 30 October 2020 (UTC)

Hi, @Seppl2013, thank you for the solution. In order to do some combability with the old synaxis, <pdf>File:Name-of-the-file.pdf</pdf>, I've made an additional fix in my local copy of PDFEmbed.hooks.php in this way:

$filename = $re[1];
if (count($re) == 3) {
	$page = $re[2];
}
// the next lines are new
$ns_media_wiki_lang = MediaWiki\MediaWikiServices::getInstance()->getContentLanguage()->getFormattedNsText( NS_MEDIA );
$ns_file_wiki_lang = MediaWiki\MediaWikiServices::getInstance()->getContentLanguage()->getFormattedNsText( NS_FILE );
$ns_media_lang_en = MediaWiki\MediaWikiServices::getInstance()->getLanguageFactory()->getLanguage( 'en' )->getFormattedNsText( NS_MEDIA );
$ns_file_lang_en = MediaWiki\MediaWikiServices::getInstance()->getLanguageFactory()->getLanguage( 'en' )->getFormattedNsText( NS_FILE );
$filename = preg_replace("/^($ns_media_wiki_lang|$ns_file_wiki_lang|$ns_media_lang_en|$ns_file_lang_en):/", '', $filename);

Spas.Z.Spasov (talk) 11:58, 5 November 2020 (UTC)

FYI, I received a "File does not exist error" using Seppl2013's clone and it worked again after introducing Spas.Z.Spasov's changes. Thanks to you both! Andreas Wachowski (talk) 17:00, 6 November 2020 (UTC)

see https://github.com/WolfgangFahl/PDFEmbed/issues/3 for the fix Seppl2013 (talk) 09:38, 13 November 2020 (UTC)

Error in MW1.35

MW 1_35 [X8eQyvnuCLpleT1MwUtyYgAAOQk] Exception caught: Call to undefined method Parser::disableCache()

I got 'Internal Error'

I had this error in 1.35.1:

'Internal Error [1e3bd7042d4fdba8255c57a6] 2021-03-30 19:32:36: Fatal exception of type "Error" '

How can I run properly this plugin? 46.196.156.167 (talk) 19:35, 30 March 2021 (UTC)

Internal Error

Internal error

[cd8dca3e4334fb046fddfec9] 2021-03-30 20:54:25: Fatal exception of type "Error"

I am getting the following error when trying to use PDFEmbed v2.02 on 1.35.1 64.140.229.250 (talk) 20:58, 30 March 2021 (UTC)

I have same problem with the same versions. Disabling PdfHandler didn't resolve the issue. 149.135.47.233 (talk) 03:04, 31 March 2021 (UTC)

Same problem here: 2021-03-31 03:38:08: Fatal exception of type "Error"

Same versions. 103.108.94.8 (talk) 04:03, 31 March 2021 (UTC)

Same Error here on any page that includes <pdf>File:Example.pdf</pdf> or any version of it (eg with height) the page won't even save if this is on it.

Just upgraded to version 1.35.1 200.25.6.85 (talk) 04:34, 31 March 2021 (UTC)

Hi,

I solve this issue by this fork

https://github.com/WolfgangFahl/PDFEmbed

You can try. Lambdacoresw (talk) 17:05, 31 March 2021 (UTC)

Yes this worked for me as well! 64.140.229.250 (talk) 15:35, 2 April 2021 (UTC)

it worked for me too, thanks ! Yannick Bravo (talk) 03:42, 14 April 2021 (UTC)

Worked for me too, thanks! Gerges massoud (talk) 14:12, 6 September 2021 (UTC)

Thanks Lambdacoresw! That worked!

I had to re-save the pages with the embed code in, otherwise I got a permission error. After that, all good! 149.135.47.233 (talk) 23:06, 31 March 2021 (UTC)

Downloaded the fork and didn't fix it for me argh. On Mediawiki version 1.31.16. It seems maybe I need to upgrade to a newer Mediawiki but doing this seems very complex. Is there any other fix? Chrisgmay16 (talk) 06:26, 8 September 2022 (UTC)