Extension talk:QRCodeOnLoad
| This page used the Structured Discussions extension to give structured discussions. It has since been converted to wikitext, so the content and history here are only an approximation of what was actually displayed at the time these comments were made. |
Adding trailing ?>
| RESOLVED | |
Do not add a trailing ?> to your code. |
|
The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
I have added a trailing php close tag ?> which is required to run this software. User User:Jack_Phoenix has reverted this edit, (perhaps by mistake?) but I plan to revert back. Please Jack_Phoenix let me know your rational for reverting. Kramer (talk) 14:48, 14 July 2013 (UTC)
- No, was not a mistake, but a very intentional change.
- The PHP trailing ?> has been considered harmful since 2007 (see r23531 for some more details) and it is not needed in pure PHP files. (Obviously it is needed if you mix, say, HTML and PHP via something like QuickTemplate, for example.)
- Since 2009, MediaWiki.org has had an AbuseFilter in place to tag edits in which users add that unnecessary closing tag. Perhaps that filter should also display a warning message?
- So yes, let's not add the PHP closing tag unless it's really necessary — which, by the way, it isn't in most cases. :-) Jack Phoenix (Contact) 15:26, 14 July 2013 (UTC)
{{#QRCodeOnLoad:}} produces error on pages
| RESOLVED | |
| The documentation was amended to help avoiding the error reported. | |
The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
When using the parser function as suggestet in the doc it rises the error below due to a missing 3rd parameter.
{{#QRCodeOnLoad:}}
Warning: Missing argument 3 for QRCodeOnLoad() in /..../extensions/QRCodeOnLoad/QRCodeOnLoad.php on line 43
Use
{{#QRCodeOnLoad:| }}
instead. Carchaias (talk) 15:17, 24 November 2016 (UTC)
- Thanks for reporting. I have updated the page accordingly. [[kgh]] (talk) 15:55, 24 November 2016 (UTC)