MediaWiki talk:Gadget-GalleryDetails.js

Category:Gadget scripts#Gallery%20Details

Archives
Conversations older than 7 days will be archived automatically.

Searchpage

I'm planning to get rid of the table element on the special search page and it seems that this gadgets makes an assumption about the searchResultImage being a table. While it won't throw an error, the functionality of this gadget is unlikely to function until the assumption about image results on the page being a table are amended. —TheDJ (talkcontribs) 07:59, 4 May 2024 (UTC)

Either table cells or divs, please add some margin to them so it can be clicked on by Cat-a-lot, as I have been begging for more than 1y. Thousands of simple dissiminating edits in crowded categories are not being done due to this issue alone. -- Tuválkin 00:53, 2 October 2024 (UTC)

Dark mode

{{Editr}} insert after line 227, 339

ndiv.style.background = "var(--background-color-interactive-subtle, #EEE)";

change line 371 to

var tools = $('<div style="font-size: small; margin: 8px; background: var(--background-color-interactive-subtle, #EEE);"></div>');

i think these changes should get rid of most white background in dark mode. sorry my html skills are rudimentary. this is all i can figure out. RoyZuo (talk) 08:33, 25 April 2025 (UTC)

@RoyZuo: The current background in line 371 is #DDD, whereas the usual fallback for background-color-interactive-subtle would be #f8f9fa (see Codex color tokens); is there a reason to use #EEE instead here? Otherwise I’d just go with the Codex value. Lucas Werkmeister (talk) 11:44, 26 April 2025 (UTC)
@Lucas Werkmeister no, i just picked randomly, wanting something a bit darker than ddd. i'm unaware of the codex.
there's a problem though. it seems after setting line 371 to background: var(... , it no longer has this special colour (right now ddd) of its own when on light mode. i dont know how to retain this. for me it's unimportant.
so i added the margin setting to distinguish that part from the box preceding it. RoyZuo (talk) 12:49, 26 April 2025 (UTC)
✓ Done – I changed that part to background-color-interactive (not -subtle) to set it apart in a different way. --Lucas Werkmeister (talk) 17:10, 28 April 2025 (UTC)
@Lucas Werkmeister thx a lot.
i'm not sure if this will fix it for the td cells:
insert
.gallery_details td {
background: var(--background-color-interactive-subtle, #f8f9fa);
}
to MediaWiki:Common.css. RoyZuo (talk) 17:53, 28 April 2025 (UTC)
oh it actually is here MediaWiki:Common.css#L-542. RoyZuo (talk) 17:57, 28 April 2025 (UTC)
table.gallery_details tr:hover td {
background: var(--background-color-interactive-hover, #f8f9fa);
}
i was thinking, would this be an interesting feature? would it feel like a hover highlight effect? RoyZuo (talk) 18:08, 28 April 2025 (UTC)
I don’t know, I have no idea where else those styles apply… if you want to suggest this, IMHO it should definitely be proposed at MediaWiki talk:common.css, where more people are likely to see it. Lucas Werkmeister (talk) 19:32, 28 April 2025 (UTC)
Category:Gadget scripts